Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] hhea.Descender should be negative for descent below the baseline #1738

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[docs] hhea.Descender should be negative for descent below the baseline #1738

wants to merge 1 commit into from
+1 −1

Conversation

TakWolf
Copy link

@TakWolf TakWolf commented Mar 14, 2024 •
edited
Loading

Description

Refer to: https://glyphsapp.com/learn/vertical-metrics

hhea:
hheaAscender: the height of the ascenders in units
hheaDescender: the depth of the descenders in units (negative value) # <----- This
hheaLineGap: the recommended whitespace between lines

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@TakWolf
Fix docs: hhea.Descender should be negative for descent below the bas…
049fc6b 
…eline

Refer to: https://glyphsapp.com/learn/vertical-metrics
hheaDescender: the depth of the descenders in units (negative value)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TakWolf